thirdpartymirrors/N64Recomp
1
0
Fork 0
mirror of https://github.com/N64Recomp/N64Recomp.git synced 2026-04-29 21:42:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fixed incorrect size used for finding section segments

Browse source
This commit is contained in:
Mr-Wiseguy 2024-08-24 22:26:42 -04:00
parent 49c3628a76
commit 688c4a2537
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/elf.cpp
View file

@ -239,10 +239,11 @@ ELFIO::section* read_sections(N64Recomp::Context& context, const N64Recomp::ElfP
auto& section_out = context.sections[section->get_index()]; auto& section_out = context.sections[section->get_index()];
ELFIO::Elf_Word type = section->get_type(); ELFIO::Elf_Word type = section->get_type();
ELFIO::Elf_Xword flags = section->get_flags(); ELFIO::Elf_Xword flags = section->get_flags();
ELFIO::Elf_Xword section_size = section->get_size();
// Check if this section will end up in the ROM. It must not be a nobits (NOLOAD) type, must have the alloc flag set and must have a nonzero size. // Check if this section will end up in the ROM. It must not be a nobits (NOLOAD) type, must have the alloc flag set and must have a nonzero size.
if (type != ELFIO::SHT_NOBITS && (section->get_flags() & ELFIO::SHF_ALLOC) && section->get_size() != 0) { if (type != ELFIO::SHT_NOBITS && (flags & ELFIO::SHF_ALLOC) && section_size != 0) {
std::optional<size_t> segment_index = get_segment(segments, section_out.size, section->get_offset()); std::optional<size_t> segment_index = get_segment(segments, section_size, section->get_offset());
if (!segment_index.has_value()) { if (!segment_index.has_value()) {
fmt::print(stderr, "Could not find segment that section {} belongs to!\n", section->get_name()); fmt::print(stderr, "Could not find segment that section {} belongs to!\n", section->get_name());
return nullptr; return nullptr;