thirdpartymirrors/RingRacers
1
0
Fork 0
mirror of https://github.com/KartKrewDev/RingRacers.git synced 2025-10-30 08:01:28 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

promote, demote: bounds checking, remove intermediate buffer

Browse source 
- Check playernum is in range [0, MAXPLAYERS-1]
- Do not copy string to intermediate buffer
This commit is contained in:
James R 2024-02-09 06:50:12 -08:00
parent da84a94362
commit 10800f307c
1 changed files with 10 additions and 24 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

34
src/d_netcmd.c
View file

@ -3861,10 +3861,6 @@ void RemoveAdminPlayer(INT32 playernum)
static void Command_Verify_f(void) static void Command_Verify_f(void)
{ {
char buf[8]; // Should be plenty
char *temp;
INT32 playernum;
if (client) if (client)
{ {
CONS_Printf(M_GetText("Only the server can use this.\n")); CONS_Printf(M_GetText("Only the server can use this.\n"));
@ -3883,16 +3879,13 @@ static void Command_Verify_f(void)
return; return;
} }
strlcpy(buf, COM_Argv(1), sizeof (buf)); INT32 playernum = atoi(COM_Argv(1));
playernum = atoi(buf); if (playernum >= 0 && playernum < MAXPLAYERS && playeringame[playernum])
{
temp = buf; UINT8 buf[1] = {playernum};
WRITEUINT8(temp, playernum);
if (playeringame[playernum])
SendNetXCmd(XD_VERIFIED, buf, 1); SendNetXCmd(XD_VERIFIED, buf, 1);
}
} }
static void Got_Verification(UINT8 **cp, INT32 playernum) static void Got_Verification(UINT8 **cp, INT32 playernum)
@ -3917,10 +3910,6 @@ static void Got_Verification(UINT8 **cp, INT32 playernum)
static void Command_RemoveAdmin_f(void) static void Command_RemoveAdmin_f(void)
{ {
char buf[8]; // Should be plenty
char *temp;
INT32 playernum;
if (client) if (client)
{ {
CONS_Printf(M_GetText("Only the server can use this.\n")); CONS_Printf(M_GetText("Only the server can use this.\n"));
@ -3933,16 +3922,13 @@ static void Command_RemoveAdmin_f(void)
return; return;
} }
strlcpy(buf, COM_Argv(1), sizeof(buf)); INT32 playernum = atoi(COM_Argv(1));
playernum = atoi(buf); if (playernum >= 0 && playernum < MAXPLAYERS && playeringame[playernum])
{
temp = buf; UINT8 buf[1] = {playernum};
WRITEUINT8(temp, playernum);
if (playeringame[playernum])
SendNetXCmd(XD_DEMOTED, buf, 1); SendNetXCmd(XD_DEMOTED, buf, 1);
}
} }
static void Got_Removal(UINT8 **cp, INT32 playernum) static void Got_Removal(UINT8 **cp, INT32 playernum)