From 1813ea562e612f8424289a855f5fdc986a0694eb Mon Sep 17 00:00:00 2001 From: AJ Martinez Date: Tue, 27 Feb 2024 02:46:12 -0700 Subject: [PATCH] Warn about OpenGL's shortcomings --- src/menus/options-video-gl.c | 31 ++++++++++++++++++++++++++----- src/screen.c | 2 +- 2 files changed, 27 insertions(+), 6 deletions(-) diff --git a/src/menus/options-video-gl.c b/src/menus/options-video-gl.c index aed46dcb1..4c63601d1 100644 --- a/src/menus/options-video-gl.c +++ b/src/menus/options-video-gl.c @@ -7,13 +7,34 @@ menuitem_t OPTIONS_VideoOGL[] = { - {IT_STRING | IT_CVAR, "Renderer", "Change renderers between Software and OpenGL", - NULL, {.cvar = &cv_renderer}, 0, 0}, - - {IT_SPACE | IT_NOTHING, NULL, NULL, + {IT_HEADER, "Rendering Backend...", "Watch people get confused anyway!!", NULL, {NULL}, 0, 0}, - {IT_HEADER, "OpenGL Options...", "Watch people get confused anyway!!", + {IT_STRING | IT_SPACE, "Legacy GL supports 3D models and true", "", + NULL, {NULL}, 0, 0}, + + {IT_STRING | IT_SPACE, "perspective, but many visual features", "", + NULL, {NULL}, 0, 0}, + + {IT_STRING | IT_SPACE, "are missing/broken.", "", + NULL, {NULL}, 0, 0}, + + {IT_SPACE | IT_NOTHING, NULL, NULL, + NULL, {NULL}, 0, 0}, + + {IT_STRING | IT_SPACE, "\x85Legacy GL will eventually be replaced.", "", + NULL, {NULL}, 0, 0}, + + {IT_STRING | IT_SPACE, "\x85Please don't report visual bugs!", "", + NULL, {NULL}, 0, 0}, // Unless you've got an MR to fix them. + + {IT_SPACE | IT_NOTHING, NULL, NULL, + NULL, {NULL}, 0, 0}, + + {IT_STRING | IT_CVAR, "Renderer", "If you don't know why you're changing this, leave it on Software!", + NULL, {.cvar = &cv_renderer}, 0, 0}, + + {IT_HEADER, "Legacy GL Options...", "Watch people get confused anyway!!", NULL, {NULL}, 0, 0}, {IT_STRING | IT_CVAR, "3D Models", "Use 3D models instead of sprites when applicable.", diff --git a/src/screen.c b/src/screen.c index 8d5691dd2..4927b3151 100644 --- a/src/screen.c +++ b/src/screen.c @@ -58,7 +58,7 @@ UINT8 setrenderneeded = 0; CV_PossibleValue_t cv_renderer_t[] = { {1, "Software"}, #ifdef HWRENDER - {2, "OpenGL"}, + {2, "Legacy GL"}, #endif {0, NULL} };