Always cache EMEMAP/SUPMAP in PU_HUDGFX tag

These particular patches need to be cached in
K_LoadKartHUDGraphics, but caching them anywhere else with a
different tag causes them to potentially be freed and then later
use-after-freed during a Sealed Star run, causing a crash. Instead,
let's cache them as PU_HUDGFX in all cases where they are used.

Fixes KartKrew/Kart#1240
This commit is contained in:
Eidolon 2024-04-30 17:03:17 -05:00
parent f4e023a38e
commit 20ea98d563
2 changed files with 3 additions and 3 deletions

View file

@ -1295,7 +1295,7 @@ void F_GameEvaluationDrawer(void)
patch_t *empat = W_CachePatchName( patch_t *empat = W_CachePatchName(
(evaluationtype == EVAL_CHAOS) ? "EMEMAP" : "SUPMAP", (evaluationtype == EVAL_CHAOS) ? "EMEMAP" : "SUPMAP",
PU_PATCH_LOWPRIORITY PU_HUDGFX
); );
x -= 6*FRACUNIT; x -= 6*FRACUNIT;
y -= 6*FRACUNIT; y -= 6*FRACUNIT;

View file

@ -3098,7 +3098,7 @@ windataemeraldmaybe:
colormap ? '\0' : 'B' colormap ? '\0' : 'B'
); );
V_DrawFixedPatch((rankx)*FRACUNIT, (ranky)*FRACUNIT, FRACUNIT, 0, W_CachePatchName(emname, PU_CACHE), colormap); V_DrawFixedPatch((rankx)*FRACUNIT, (ranky)*FRACUNIT, FRACUNIT, 0, W_CachePatchName(emname, PU_HUDGFX), colormap);
} }
} }
else if (statsmode) else if (statsmode)