thirdpartymirrors/RingRacers
1
0
Fork 0
mirror of https://github.com/KartKrewDev/RingRacers.git synced 2025-10-30 08:01:28 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

R_AddPrecipitationSprites: fix use of th after freed

Browse source 
R_ProjectPrecipitationSprite may free th
This commit is contained in:
James R 2024-02-08 18:37:01 -08:00
parent 56e710266c
commit 42146c5ea2
1 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/r_things.cpp
View file

@ -2843,7 +2843,7 @@ void R_AddPrecipitationSprites(void)
const fixed_t drawdist = cv_drawdist_precip.value * mapobjectscale; const fixed_t drawdist = cv_drawdist_precip.value * mapobjectscale;
INT32 xl, xh, yl, yh, bx, by; INT32 xl, xh, yl, yh, bx, by;
precipmobj_t *th; precipmobj_t *th, *next;
// no, no infinite draw distance for precipitation. this option at zero is supposed to turn it off // no, no infinite draw distance for precipitation. this option at zero is supposed to turn it off
if (drawdist == 0) if (drawdist == 0)
@ -2863,8 +2863,11 @@ void R_AddPrecipitationSprites(void)
{ {
for (by = yl; by <= yh; by++) for (by = yl; by <= yh; by++)
{ {
for (th = precipblocklinks[(by * bmapwidth) + bx]; th; th = th->bnext) for (th = precipblocklinks[(by * bmapwidth) + bx]; th; th = next)
{ {
// Store this beforehand because R_ProjectPrecipitionSprite may free th (see P_PrecipThinker)
next = th->bnext;
if (R_PrecipThingVisible(th)) if (R_PrecipThingVisible(th))
{ {
R_ProjectPrecipitationSprite(th); R_ProjectPrecipitationSprite(th);