From 5afc783c78e478cc34cbb8e2e29d3d3e62d6fa22 Mon Sep 17 00:00:00 2001
From: TehRealSalt <tehrealsalt@gmail.com>
Date: Mon, 26 Nov 2018 05:09:56 -0500
Subject: [PATCH] Calculate buffer size manually

(Yes, I checked; this always outputs "3" for its current usage.)
---
 src/g_game.c | 13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)

diff --git a/src/g_game.c b/src/g_game.c
index c6acb3941..9d7ebbb44 100644
--- a/src/g_game.c
+++ b/src/g_game.c
@@ -3273,11 +3273,20 @@ INT16 G_RandMap(INT16 tolflags, INT16 pprevmap, boolean ignorebuffer, UINT8 maph
 {
 	INT32 numokmaps = 0;
 	INT16 ix, bufx;
+	UINT16 extbufsize = 0;
 	boolean usehellmaps; // Only consider Hell maps in this pick
 
 	if (!okmaps)
 		okmaps = Z_Malloc(NUMMAPS * sizeof(INT16), PU_STATIC, NULL);
 
+	if (extbuffer != NULL)
+	{
+		bufx = 0;
+		while (extbuffer[bufx]) {
+			extbufsize++; bufx++;
+		}
+	}
+
 tryagain:
 
 	usehellmaps = (maphell == 0 ? false : (maphell == 2 || M_RandomChance(FRACUNIT/100))); // 1% chance of Hell
@@ -3298,9 +3307,9 @@ tryagain:
 
 		if (!ignorebuffer)
 		{
-			if (extbuffer != NULL)
+			if (extbufsize > 0)
 			{
-				for (bufx = 0; bufx < (INT16)(sizeof extbuffer); bufx++)
+				for (bufx = 0; bufx < extbufsize; bufx++)
 				{
 					if (extbuffer[bufx] == -1) // Rest of buffer SHOULD be empty
 						break;