From 77e5bb4d19ff2eff4ff6532c5e43df2c0263bcf0 Mon Sep 17 00:00:00 2001 From: James R Date: Wed, 29 Mar 2023 03:18:40 -0700 Subject: [PATCH] line 448: fix skybox mobj reference leak Calling P_SetTarget on the temporary skybox_t is pointless. P_SwitchSkybox calls P_SetTarget when copying to the player struct. --- src/p_spec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/p_spec.c b/src/p_spec.c index 79fde7570..3d4cbabcd 100644 --- a/src/p_spec.c +++ b/src/p_spec.c @@ -3707,7 +3707,7 @@ boolean P_ProcessSpecial(activator_t *activator, INT16 special, INT32 *args, cha else set = NULL; - P_SetTarget(&skybox.viewpoint, set); + skybox.viewpoint = set; } // set centerpoint mobj @@ -3718,7 +3718,7 @@ boolean P_ProcessSpecial(activator_t *activator, INT16 special, INT32 *args, cha else set = NULL; - P_SetTarget(&skybox.centerpoint, set); + skybox.centerpoint = set; } if (args[3]) // Applies to all players