From 8179b39773063428f1d600af3ca53c9e14460b2d Mon Sep 17 00:00:00 2001
From: toaster <rollerorbital@gmail.com>
Date: Sun, 27 Nov 2022 16:21:45 +0000
Subject: [PATCH] ForceAllSkins cleanup

---
 src/d_netcmd.c | 21 ++++++++++-----------
 1 file changed, 10 insertions(+), 11 deletions(-)

diff --git a/src/d_netcmd.c b/src/d_netcmd.c
index 086c4cbfa..11c919a05 100644
--- a/src/d_netcmd.c
+++ b/src/d_netcmd.c
@@ -1407,26 +1407,25 @@ boolean CanChangeSkinWhilePlaying(INT32 playernum)
 
 static void ForceAllSkins(INT32 forcedskin)
 {
-	INT32 i, j;
+	INT32 i;
 	for (i = 0; i < MAXPLAYERS; ++i)
 	{
 		if (!playeringame[i])
 			continue;
 
 		SetPlayerSkinByNum(i, forcedskin);
+	}
 
-		// If it's me (or my brother (or my sister (or my trusty pet dog))), set appropriate skin value in cv_skin
-		if (dedicated) // But don't do this for dedicated servers, of course.
+	if (dedicated)
+		return;
+
+	// If it's me (or my brother (or my sister (or my trusty pet dog))), set appropriate skin value in cv_skin
+	for (i = 0; i <= splitscreen; i++)
+	{
+		if (!playeringame[g_localplayers[i]])
 			continue;
 
-		for (j = 0; j <= splitscreen; j++)
-		{
-			if (i == g_localplayers[j])
-			{
-				CV_StealthSet(&cv_skin[j], skins[forcedskin].name);
-				break;
-			}
-		}
+		CV_StealthSet(&cv_skin[i], skins[forcedskin].name);
 	}
 }