From 851a2094cf68433ac67d41ba0e3b842d2bdf04d4 Mon Sep 17 00:00:00 2001
From: toaster <rollerorbital@gmail.com>
Date: Wed, 24 Aug 2022 15:04:09 +0100
Subject: [PATCH] Don't even attempt to advertise a non-netgame server.

This appears to be a long-time bug that exists upstream too, but nobody even knew about it before the MS rules alert made it clear this was actually happening!

# Conflicts:
#	src/m_menu.c
---
 src/d_clisrv.c | 2 +-
 src/mserv.c    | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/d_clisrv.c b/src/d_clisrv.c
index b03eb478e..e26debd91 100644
--- a/src/d_clisrv.c
+++ b/src/d_clisrv.c
@@ -3235,7 +3235,7 @@ void D_QuitNetGame(void)
 			if (nodeingame[i])
 				HSendPacket(i, true, 0, 0);
 #ifdef MASTERSERVER
-		if (serverrunning && cv_advertise.value)
+		if (serverrunning && netgame && cv_advertise.value) // see mserv.c Online()
 			UnregisterServer();
 #endif
 	}
diff --git a/src/mserv.c b/src/mserv.c
index b9d1825eb..98dd0820b 100644
--- a/src/mserv.c
+++ b/src/mserv.c
@@ -434,7 +434,7 @@ void UnregisterServer(void)
 static boolean
 Online (void)
 {
-	return ( serverrunning && cv_advertise.value );
+	return ( serverrunning && netgame && cv_advertise.value );
 }
 
 static inline void SendPingToMasterServer(void)
@@ -532,7 +532,7 @@ Advertise_OnChange(void)
 
 	if (cv_advertise.value)
 	{
-		if (serverrunning)
+		if (serverrunning && netgame)
 		{
 			Lock_state();
 			{