thirdpartymirrors/RingRacers
1
0
Fork 0
mirror of https://github.com/KartKrewDev/RingRacers.git synced 2026-02-22 21:41:31 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix G_UpdateVisited, this time in a forward-thinking way

Browse source 
- Check for if a single local player isn't spectator or no-contested.
- Clean up code to return early if exclusionary conditions are met, rather than one long if conditional bundling them together
This commit is contained in:
toaster 2022-09-26 17:15:34 +01:00
parent 4d9f19200b
commit 90578b2628
1 changed files with 35 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

49
src/g_game.c
View file

@ -3621,25 +3621,46 @@ void G_AddMapToBuffer(INT16 map)
//
static void G_UpdateVisited(void)
{
// Update visitation flags?
if (!demo.playback) // Not watching a demo
UINT8 i;
UINT8 earnedEmblems;
// No demos.
if (demo.playback)
return;
// Check if every local player wiped out.
for (i = 0; i < MAXPLAYERS; i++)
{
UINT8 earnedEmblems;
if (!playeringame[i]) // Not here.
continue;
// Update visitation flags
mapheaderinfo[gamemap-1]->mapvisited |= MV_BEATEN;
if (!P_IsLocalPlayer(&players[i])) // Not local.
continue;
if (encoremode == true)
{
mapheaderinfo[gamemap-1]->mapvisited |= MV_ENCORE;
}
if (players[i].spectator) // Not playing.
continue;
if (modeattacking)
G_UpdateRecordReplays();
if ((earnedEmblems = M_CompletionEmblems()))
CONS_Printf(M_GetText("\x82" "Earned %hu emblem%s for level completion.\n"), (UINT16)earnedEmblems, earnedEmblems > 1 ? "s" : "");
if (players[i].pflags & PF_NOCONTEST) // Sonic after not surviving.
continue;
break;
}
if (i == MAXPLAYERS) // Not a single living local soul?
return;
// Update visitation flags
mapheaderinfo[gamemap-1]->mapvisited |= MV_BEATEN;
if (encoremode == true)
{
mapheaderinfo[gamemap-1]->mapvisited |= MV_ENCORE;
}
if (modeattacking)
G_UpdateRecordReplays();
if ((earnedEmblems = M_CompletionEmblems()))
CONS_Printf(M_GetText("\x82" "Earned %hu emblem%s for level completion.\n"), (UINT16)earnedEmblems, earnedEmblems > 1 ? "s" : "");
}
static boolean CanSaveLevel(INT32 mapnum)