From 9a1de18491fbb437cca091ef92c0360559aa27b8 Mon Sep 17 00:00:00 2001 From: AJ Martinez Date: Tue, 28 Mar 2023 03:07:52 -0700 Subject: [PATCH] Fix memory leak in GetPrettyRRID --- src/k_profiles.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/src/k_profiles.c b/src/k_profiles.c index e2c2b3401..a97ca1ae9 100644 --- a/src/k_profiles.c +++ b/src/k_profiles.c @@ -595,9 +595,10 @@ boolean PR_IsLocalPlayerGuest(INT32 player) return !(cv_lastprofile[player].value); } +static char rrid_buf[256]; + char *GetPrettyRRID(const unsigned char *bin, boolean brief) { - char *out; size_t i; size_t len = 32; @@ -607,15 +608,13 @@ char *GetPrettyRRID(const unsigned char *bin, boolean brief) if (bin == NULL || len == 0) return NULL; - out = malloc(len*2 + 1); - for (i=0; i> 4]; - out[i*2+1] = "0123456789ABCDEF"[bin[i] & 0x0F]; + rrid_buf[i*2] = "0123456789ABCDEF"[bin[i] >> 4]; + rrid_buf[i*2+1] = "0123456789ABCDEF"[bin[i] & 0x0F]; } - out[len*2] = '\0'; + rrid_buf[len*2] = '\0'; - return out; + return rrid_buf; }