From 971eed8d9726ca037f48ebca7d6c0909618549c5 Mon Sep 17 00:00:00 2001 From: James R Date: Thu, 26 Sep 2019 16:35:41 -0700 Subject: [PATCH 1/2] abs is unnecessary on unsigned types --- src/k_kart.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/k_kart.c b/src/k_kart.c index fce8b4ff6..fe8902257 100644 --- a/src/k_kart.c +++ b/src/k_kart.c @@ -1623,7 +1623,7 @@ static void K_DrawDraftCombiring(player_t *player, player_t *victim, fixed_t cur cury + (P_RandomRange(-12,12)*mapobjectscale), curz + (P_RandomRange(24,48)*mapobjectscale), MT_SIGNSPARKLE); - P_SetMobjState(band, S_SIGNSPARK1 + (abs(leveltime+offset) % 11)); + P_SetMobjState(band, S_SIGNSPARK1 + ((leveltime+offset) % 11)); P_SetScale(band, (band->destscale = (3*player->mo->scale)/2)); band->color = colors[c]; band->colorized = true; From 739d602c84ca79cf972a76b07aed0830109a8055 Mon Sep 17 00:00:00 2001 From: James R Date: Thu, 26 Sep 2019 16:41:02 -0700 Subject: [PATCH 2/2] Addition unecessary as ruled out by if condition --- src/k_kart.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/k_kart.c b/src/k_kart.c index fe8902257..2015cbf39 100644 --- a/src/k_kart.c +++ b/src/k_kart.c @@ -1623,7 +1623,7 @@ static void K_DrawDraftCombiring(player_t *player, player_t *victim, fixed_t cur cury + (P_RandomRange(-12,12)*mapobjectscale), curz + (P_RandomRange(24,48)*mapobjectscale), MT_SIGNSPARKLE); - P_SetMobjState(band, S_SIGNSPARK1 + ((leveltime+offset) % 11)); + P_SetMobjState(band, S_SIGNSPARK1 + (leveltime % 11)); P_SetScale(band, (band->destscale = (3*player->mo->scale)/2)); band->color = colors[c]; band->colorized = true;