thirdpartymirrors/RingRacers
1
0
Fork 0
mirror of https://github.com/KartKrewDev/RingRacers.git synced 2026-04-27 04:21:47 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Y_PlayerStandingsDrawer: Make player index referencing in loop cleaner

Browse source
This commit is contained in:
toaster 2023-05-11 16:46:03 +01:00
parent c712cd7452
commit efa849c8cc
1 changed files with 10 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
src/y_inter.c
View file

@ -484,12 +484,14 @@ void Y_PlayerStandingsDrawer(INT32 xoffset)
for (i = 0; i < data.numplayers; i++) for (i = 0; i < data.numplayers; i++)
{ {
boolean dojitter = data.jitter[data.num[i]] > 0; const UINT8 pnum = data.num[i];
data.jitter[data.num[i]] = 0;
if (data.num[i] == MAXPLAYERS) boolean dojitter = data.jitter[pnum] > 0;
data.jitter[pnum] = 0;
if (pnum == MAXPLAYERS)
; ;
else if (!playeringame[data.num[i]] || players[data.num[i]].spectator == true) else if (!playeringame[pnum] || players[pnum].spectator == true)
data.num[i] = MAXPLAYERS; // this should be the only field setting in this function data.num[i] = MAXPLAYERS; // this should be the only field setting in this function
else else
{ {
@ -503,7 +505,7 @@ void Y_PlayerStandingsDrawer(INT32 xoffset)
if (data.color[i]) if (data.color[i])
{ {
UINT8 *charcolormap; UINT8 *charcolormap;
if (data.rankingsmode == 0 && (players[data.num[i]].pflags & PF_NOCONTEST) && players[data.num[i]].bot) if (data.rankingsmode == 0 && (players[pnum].pflags & PF_NOCONTEST) && players[pnum].bot)
{ {
// RETIRED !! // RETIRED !!
charcolormap = R_GetTranslationColormap(TC_DEFAULT, data.color[i], GTC_CACHE); charcolormap = R_GetTranslationColormap(TC_DEFAULT, data.color[i], GTC_CACHE);
@ -518,7 +520,7 @@ void Y_PlayerStandingsDrawer(INT32 xoffset)
/* y2 = y; /* y2 = y;
if ((netgame || (demo.playback && demo.netgame)) && playerconsole[data.num[i]] == 0 && server_lagless && !players[data.num[i]].bot) if ((netgame || (demo.playback && demo.netgame)) && playerconsole[pnum] == 0 && server_lagless && !players[pnum].bot)
{ {
static UINT8 alagles_timer = 0; static UINT8 alagles_timer = 0;
patch_t *alagles; patch_t *alagles;
@ -550,11 +552,11 @@ void Y_PlayerStandingsDrawer(INT32 xoffset)
V_DrawThinString( V_DrawThinString(
x+27, y-2, x+27, y-2,
( (
_isHighlightedPlayer(&players[data.num[i]]) _isHighlightedPlayer(&players[pnum])
? hilicol ? hilicol
: 0 : 0
)|V_ALLOWLOWERCASE|V_6WIDTHSPACE, )|V_ALLOWLOWERCASE|V_6WIDTHSPACE,
player_names[data.num[i]] player_names[pnum]
); );
V_DrawRightAlignedThinString( V_DrawRightAlignedThinString(