Merge branch 'werror-solving' into 'master'

Werror solving (180525)

See merge request kart-krew-dev/ring-racers-internal!2547

src/apng.c

@@ -71,7 +71,7 @@ apng_create_info_struct (png_structp pngp)
 {
 	apng_infop ainfop;
 	(void)pngp;
-	if (( ainfop = calloc(sizeof (apng_info),1) ))
+	if (( ainfop = calloc(1, sizeof (apng_info)) ))
 	{
 		apng_set_write_fn(pngp, ainfop, 0, 0, 0, 0, 0);
 		apng_set_set_acTL_fn(pngp, ainfop, 0);

src/d_main.cpp

@@ -1306,7 +1306,8 @@ static void D_AddFile(initmultiplefilesentry_t *list, size_t index, const char *
 
 static inline void D_CleanFile(initmultiplefilesentry_t *list, size_t count)
 {
-	for (INT32 i = 0; i < count; ++i)
+	size_t i;
+	for (i = 0; i < count; ++i)
 	{
 		if (list[i].filename != NULL)
 			free((void*)list[i].filename);

src/hardware/hw_md2.c

@@ -826,10 +826,9 @@ static void HWR_CreateBlendedTexture(patch_t *gpatch, patch_t *blendgpatch, GLMi
 				}
 			}
 		}
-	}
 
-	if (translen > 0)
 		colorbrightnesses[translen] = colorbrightnesses[translen-1];
+	}
 
 	if (skinnum == TC_BLINK)
 		blendcolor = V_GetColor(skincolors[color].ramp[3]);

src/i_tcp_detail.h

@@ -40,8 +40,6 @@ extern "C" {
 	#include <ws2tcpip.h>
 #endif
 
-#include "doomdef.h"
-
 #ifdef USE_WINSOCK1
 	#include <winsock.h>
 #else
@@ -115,9 +113,11 @@ extern "C" {
 	static UINT8 UPNP_support = TRUE;
 #endif // HAVE_MINIUPNC
 
-#include "d_net.h"
-#include "doomtype.h"
 #include "i_tcp.h"
+#include "d_net.h"
+
+#include "doomdef.h"
+#include "doomtype.h"
 
 union mysockaddr_t
 {

src/k_bans.cpp

@@ -17,10 +17,11 @@
 #include <fmt/format.h>
 #include <tcb/span.hpp>
 
+#include "i_tcp_detail.h" // clientaddress
+
 #include "core/json.hpp"
 #include "core/string.h"
 #include "io/streams.hpp"
-#include "i_tcp_detail.h" // clientaddress
 #include "k_bans.h"
 #include "byteptr.h" // READ/WRITE macros
 #include "command.h"

src/k_kart.c

@@ -13882,9 +13882,10 @@ void K_MoveKartPlayer(player_t *player, boolean onground)
 								player->itemamount--;
 								if (player->throwdir > 0)
 								{
-									mobj_t *landmine = K_ThrowKartItem(player, true, MT_LANDMINE, -1, 0, 0);
+									K_ThrowKartItem(player, true, MT_LANDMINE, -1, 0, 0);
 								}
-								else {
+								else
+								{
 									K_ThrowLandMine(player);
 								}
 								K_PlayAttackTaunt(player->mo);

src/media/webm_vorbis_lace.cpp

@@ -61,7 +61,8 @@ std::vector<std::byte> WebmVorbisEncoder::make_vorbis_private_data()
 
 	// The first byte is the number of packets. Once again,
 	// the last packet is not counted.
-	v.emplace_back(std::byte {2});
+	v.resize(1);
+	v[0] = std::byte {2};
 
 	// Then the laced sizes for each packet.
 	lace(v, packets[0]);

src/objects/checkpoint.cpp

@@ -495,7 +495,7 @@ struct CheckpointManager
 		else // Checkpoint isn't in the list, find any associated tagged lines and make the pair
 		{
 			if (chk->linetag())
-				lines_.try_emplace(chk->linetag(), std::move(tagged_lines(chk->linetag())));
+				lines_.try_emplace(chk->linetag(), tagged_lines(chk->linetag()));
 			list_.push_front(chk);
 			count_ += 1; // Mobjlist can't have a count on it, so we keep it here
 		}