From db7892d15a1b33189d891392413da2acad1a1569 Mon Sep 17 00:00:00 2001 From: James R Date: Sun, 3 Mar 2024 00:32:38 -0800 Subject: [PATCH] Comment out SCRAMBLE_REMOVED - Scramble can help point out memory leaks from mobjs never being freed - However it can also cause false positive crashes, since there is sometimes a 1 or 2 tic window between when P_RemoveMobj is called and all pointers to that mobj are set to NULL - Presumably we have code that NULL checks but does not check P_MobjWasRemoved and such instances may be hard to find so it's just easier to not scramble --- src/p_mobj.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/p_mobj.c b/src/p_mobj.c index 12bf519bf..a686fa609 100644 --- a/src/p_mobj.c +++ b/src/p_mobj.c @@ -11290,7 +11290,7 @@ tic_t itemrespawntime[ITEMQUESIZE]; size_t iquehead, iquetail; #ifdef PARANOIA -#define SCRAMBLE_REMOVED // Force debug build to crash when Removed mobj is accessed +//#define SCRAMBLE_REMOVED // Force debug build to crash when Removed mobj is accessed #endif void P_RemoveMobj(mobj_t *mobj) {