From ff926440d5598c0a9cedcc73a8b70cff46e26fb7 Mon Sep 17 00:00:00 2001 From: toaster Date: Mon, 6 Mar 2023 22:38:37 +0000 Subject: [PATCH] UCRP_WETPLAYER: Adjust SOC load to not Z_StrDup before confirming other data is valid, to prevent memory leak --- src/deh_soc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/deh_soc.c b/src/deh_soc.c index 9c853e0ab..08b1771e6 100644 --- a/src/deh_soc.c +++ b/src/deh_soc.c @@ -2643,7 +2643,6 @@ static void readcondition(UINT8 set, UINT32 id, char *word2) ty = UCRP_WETPLAYER; re = MFE_UNDERWATER; x1 = 1; - stringvar = Z_StrDup(params[1]); if (params[2]) { @@ -2655,6 +2654,8 @@ static void readcondition(UINT8 set, UINT32 id, char *word2) return; } } + + stringvar = Z_StrDup(params[1]); } else {