From f160be4bbac7c2ddd48def7de94cfff8e1d3a202 Mon Sep 17 00:00:00 2001
From: Hyper <34012267+hyperbx@users.noreply.github.com>
Date: Fri, 28 Mar 2025 12:47:18 +0000
Subject: [PATCH] Make status success by default or on file not existing

---
 UnleashedRecomp/user/achievement_manager.cpp        | 5 +----
 UnleashedRecomp/user/achievement_manager.h          | 4 +---
 UnleashedRecomp/user/persistent_storage_manager.cpp | 5 +----
 UnleashedRecomp/user/persistent_storage_manager.h   | 4 +---
 4 files changed, 4 insertions(+), 14 deletions(-)

diff --git a/UnleashedRecomp/user/achievement_manager.cpp b/UnleashedRecomp/user/achievement_manager.cpp
index 60ca199d..251d5bb9 100644
--- a/UnleashedRecomp/user/achievement_manager.cpp
+++ b/UnleashedRecomp/user/achievement_manager.cpp
@@ -100,10 +100,7 @@ bool AchievementManager::LoadBinary()
         dataPath = GetDataPath(false);
 
         if (!std::filesystem::exists(dataPath))
-        {
-            BinStatus = EAchBinStatus::NoFile;
-            return false;
-        }
+            return true;
     }
 
     std::error_code ec;
diff --git a/UnleashedRecomp/user/achievement_manager.h b/UnleashedRecomp/user/achievement_manager.h
index 4d0bf9e1..4bff7577 100644
--- a/UnleashedRecomp/user/achievement_manager.h
+++ b/UnleashedRecomp/user/achievement_manager.h
@@ -4,9 +4,7 @@
 
 enum class EAchBinStatus
 {
-    Unknown,
     Success,
-    NoFile,
     IOError,
     BadFileSize,
     BadSignature,
@@ -18,7 +16,7 @@ class AchievementManager
 {
 public:
     static inline AchievementData Data{};
-    static inline EAchBinStatus BinStatus{ EAchBinStatus::Unknown };
+    static inline EAchBinStatus BinStatus{ EAchBinStatus::Success };
 
     static std::filesystem::path GetDataPath(bool checkForMods)
     {
diff --git a/UnleashedRecomp/user/persistent_storage_manager.cpp b/UnleashedRecomp/user/persistent_storage_manager.cpp
index 231ba36e..6b92d239 100644
--- a/UnleashedRecomp/user/persistent_storage_manager.cpp
+++ b/UnleashedRecomp/user/persistent_storage_manager.cpp
@@ -46,10 +46,7 @@ bool PersistentStorageManager::LoadBinary()
         dataPath = GetDataPath(false);
 
         if (!std::filesystem::exists(dataPath))
-        {
-            BinStatus = EExtBinStatus::NoFile;
-            return false;
-        }
+            return true;
     }
 
     std::error_code ec;
diff --git a/UnleashedRecomp/user/persistent_storage_manager.h b/UnleashedRecomp/user/persistent_storage_manager.h
index 25f5b212..4cad7b88 100644
--- a/UnleashedRecomp/user/persistent_storage_manager.h
+++ b/UnleashedRecomp/user/persistent_storage_manager.h
@@ -4,9 +4,7 @@
 
 enum class EExtBinStatus
 {
-    Unknown,
     Success,
-    NoFile,
     IOError,
     BadFileSize,
     BadSignature,
@@ -17,7 +15,7 @@ class PersistentStorageManager
 {
 public:
     static inline PersistentData Data{};
-    static inline EExtBinStatus BinStatus{ EExtBinStatus::Unknown };
+    static inline EExtBinStatus BinStatus{ EExtBinStatus::Success };
 
     static std::filesystem::path GetDataPath(bool checkForMods)
     {