thirdpartymirrors/UnleashedRecomp
1
0
Fork 0
mirror of https://github.com/hedge-dev/UnleashedRecomp.git synced 2026-03-31 23:51:55 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix town npc related member variable initialization

Browse source
This commit is contained in:
DeaTh-G 2026-02-15 20:23:33 +01:00
parent 5e8695a157
commit f6b03f8769
1 changed files with 25 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

25
UnleashedRecomp/patches/misc_patches.cpp
View file

@ -193,3 +193,28 @@ PPC_FUNC(sub_824EE620)
ctx.r3.u32 = PersistentStorageManager::ShouldDisplayDLCMessage(true);
}
// This is a constructor for some struct that constructed inside CTownManContext::CTownManContext()
// and within the calls contained in CTownManBase::ProcMsgSetTownManRetryTimeTable().
//
// Within the constructor of the CTownManContext, second member of this struct is initialized to -1
// after this call happens inside CTownManContext::CTownManContext at the pretty much the very of that function call.
//
// This initialization of the member variable is however not executed when this constructor for the struct
// is called from someplace else in the game's code, as such it remains with unitialized data for that field.
//
// Ensuring that this member variable is initialized to what CTownManContext::CTownManContext sets it to
// anytime this constructor is called fixes an issue with Tails not disappearing when giving you the camera
// after Rooftop Run Act 1.
//
// NOTE: ctx.r3.u32 + 0 is also unitialized by this constructor, however both instances of this function being called
// initialized the said variable later on before being used.
//
// NOTE: ctx.r3.u32 + 20 is also unitialized, however I could not find any uses for this. Since this is already
// quite a big change due to the amount of NPCs in the game, I would rather not touch this unless an issue is found.
PPC_FUNC_IMPL(__imp__sub_8297C630);
PPC_FUNC(sub_8297C630)
{
PPC_STORE_U32(ctx.r3.u32 + 4, -1);
__imp__sub_8297C630(ctx, base);
}