thirdpartymirrors/lsfg-vk
1
0
Fork 0
mirror of https://github.com/PancakeTAS/lsfg-vk.git synced 2026-04-27 21:01:41 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

refactor(cleanup): fix string lifetimes

Browse source
This commit is contained in:
PancakeTAS 2025-12-15 14:05:09 +01:00
parent 8bff30edc5
commit 32da2283b4
No known key found for this signature in database
3 changed files with 7 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
lsfg-vk-layer/src/entrypoint.cpp
View file

@ -24,17 +24,17 @@ namespace {
/// helper function to add required extensions /// helper function to add required extensions
std::vector<const char*> add_extensions(const char* const* existingExtensions, size_t count, std::vector<const char*> add_extensions(const char* const* existingExtensions, size_t count,
const std::vector<std::string>& requiredExtensions) { const std::vector<const char*>& requiredExtensions) {
std::vector<const char*> extensions(count); std::vector<const char*> extensions(count);
std::copy_n(existingExtensions, count, extensions.data()); std::copy_n(existingExtensions, count, extensions.data());
for (const auto& requiredExtension : requiredExtensions) { for (const auto& requiredExtension : requiredExtensions) {
auto it = std::ranges::find_if(extensions, auto it = std::ranges::find_if(extensions,
[requiredExtension](const char* extension) { [requiredExtension](const char* extension) {
return std::string(extension) == requiredExtension; return std::string(extension) == std::string(requiredExtension);
}); });
if (it == extensions.end()) if (it == extensions.end())
extensions.push_back(requiredExtension.c_str()); extensions.push_back(requiredExtension);
} }
return extensions; return extensions;

4
lsfg-vk-layer/src/layer.cpp
View file

@ -49,7 +49,7 @@ bool Layer::tick() {
return true; return true;
} }
std::vector<std::string> Layer::instanceExtensions() const { std::vector<const char*> Layer::instanceExtensions() const {
if (!this->profile.has_value()) if (!this->profile.has_value())
return {}; return {};
@ -60,7 +60,7 @@ std::vector<std::string> Layer::instanceExtensions() const {
}; };
} }
std::vector<std::string> Layer::deviceExtensions() const { std::vector<const char*> Layer::deviceExtensions() const {
if (!this->profile.has_value()) if (!this->profile.has_value())
return {}; return {};

4
lsfg-vk-layer/src/layer.hpp
View file

@ -25,10 +25,10 @@ namespace lsfgvk::layer {
/// required instance extensions /// required instance extensions
/// @return list of extension names /// @return list of extension names
[[nodiscard]] std::vector<std::string> instanceExtensions() const; [[nodiscard]] std::vector<const char*> instanceExtensions() const;
/// required device extensions /// required device extensions
/// @return list of extension names /// @return list of extension names
[[nodiscard]] std::vector<std::string> deviceExtensions() const; [[nodiscard]] std::vector<const char*> deviceExtensions() const;
/// tick the layer /// tick the layer
/// @throws lsfgvk::error on failure /// @throws lsfgvk::error on failure