From 0538204fc3e39906327a49d50a760ac07b8b953f Mon Sep 17 00:00:00 2001 From: djoslin0 Date: Fri, 21 Nov 2025 11:21:14 -0800 Subject: [PATCH] Fix - Remove incorrect collision validation check (#1026) A validation check in dynos_bin_col.cpp was wrong, which would block otherwise well formed collision files. Since collisions are parsed as s16, if you reach the bounds of s16 values will begin to overflow and the validation will catch it. To work around this overflow issue, you need to output groups of triangles and vertices. However the existing check in ValidateColInit() would prevent this workaround. Now there is essentially no hard-coded limit when it comes to vertex and triangle counts of collision structs. Co-authored-by: MysterD --- data/dynos_bin_col.cpp | 3 --- 1 file changed, 3 deletions(-) diff --git a/data/dynos_bin_col.cpp b/data/dynos_bin_col.cpp index a9e88c921..cd5a58e50 100644 --- a/data/dynos_bin_col.cpp +++ b/data/dynos_bin_col.cpp @@ -64,9 +64,6 @@ static void ValidateColSectionChange(GfxData* aGfxData, struct CollisionValidati } static void ValidateColInit(GfxData* aGfxData, struct CollisionValidationData& aColValData) { - if (aColValData.tokenIndex != 0) { - PrintDataError("COL_INIT found after the first token"); - } ValidateColSectionChange(aGfxData, aColValData, COL_SECTION_VTX); }