From 933f0812a70bec164750b0b2aa96b91abacb5ce1 Mon Sep 17 00:00:00 2001
From: Isaac0-dev <62234577+Isaac0-dev@users.noreply.github.com>
Date: Mon, 6 May 2024 17:49:47 +1000
Subject: [PATCH] more bounds checks in network_receive_save_remove_flag (#25)

---
 src/pc/network/packets/packet_save_remove_flag.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/pc/network/packets/packet_save_remove_flag.c b/src/pc/network/packets/packet_save_remove_flag.c
index 179d6e790..db20e1d82 100644
--- a/src/pc/network/packets/packet_save_remove_flag.c
+++ b/src/pc/network/packets/packet_save_remove_flag.c
@@ -29,12 +29,12 @@ void network_receive_save_remove_flag(struct Packet* p) {
     packet_read(p, &flagsToRemove, sizeof(u32));
     packet_read(p, &backupSlot, sizeof(u8));
 
-    if (fileIndex >= NUM_SAVE_FILES) {
+    if (fileIndex < 0 || fileIndex >= NUM_SAVE_FILES) {
         LOG_ERROR("Invalid fileIndex: %d", fileIndex);
         return;
     }
 
-    if (courseIndex >= COURSE_COUNT) {
+    if (courseIndex < -1 || courseIndex >= COURSE_COUNT) {
         LOG_ERROR("Invalid courseIndex: %d", courseIndex);
         return;
     }