From bd5cf36c615ea52499e49566b20c5cacd05c6a5e Mon Sep 17 00:00:00 2001 From: Isaac0-dev <62234577+Isaac0-dev@users.noreply.github.com> Date: Mon, 24 Nov 2025 10:53:44 +1000 Subject: [PATCH] fix a use after free in the edit player menu --- src/pc/djui/djui_panel_player.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/pc/djui/djui_panel_player.c b/src/pc/djui/djui_panel_player.c index 48a53c8a9..9656f6552 100644 --- a/src/pc/djui/djui_panel_player.c +++ b/src/pc/djui/djui_panel_player.c @@ -205,6 +205,7 @@ static void djui_panel_player_edit_palette_destroy(struct DjuiBase* caller) { } sColorRect = NULL; + gDjuiPaletteToggle = NULL; if (sPalettePresetSelection) { sPalettePresetIndex = djui_panel_player_edit_palette_get_palette_index(configPlayerPalette); @@ -372,7 +373,7 @@ static void djui_panel_player_name_active_palette(struct DjuiBase* caller) { struct DjuiButton* button2 = djui_button_right_create(&rect3->base, DLANG(PLAYER, SAVE_PRESET), DJUI_BUTTON_STYLE_NORMAL, djui_panel_player_active_palette_export); djui_base_set_size(&button2->base, 0.485f, 32); } - + { struct DjuiText *text = djui_text_create(body, DLANG(PLAYER, CAP_TOGGLE)); djui_text_set_alignment(text, DJUI_HALIGN_CENTER, DJUI_VALIGN_TOP);