Merge branch 'robust-sigcheck' into 'master'

Don't skip signature check steps if server is lagging (resolves #715)

Closes #715

See merge request KartKrew/Kart!1554

src/d_clisrv.c

@@ -6479,7 +6479,7 @@ static void CheckPresentPlayers(void)
 }
 
 // Handle "client-to-client" auth challenge flow.
-static void UpdateChallenges(void)
+void UpdateChallenges(void)
 {
 	if (!(Playing() && netgame))
 		return;
@@ -6498,7 +6498,7 @@ static void UpdateChallenges(void)
 	}
 	else // client
 	{
-		if (leveltime <= CHALLENGEALL_START)
+		if (leveltime < CHALLENGEALL_START)
 		expectChallenge = true;
 
 		if (leveltime == CHALLENGEALL_START)
@@ -6660,8 +6660,6 @@ void NetUpdate(void)
 
 	UpdatePingTable();
 
-	UpdateChallenges();
-
 	if (client)
 		maketic = neededtic;
 

src/d_clisrv.h

@@ -620,6 +620,9 @@ void CL_TimeoutServerList(void);
 // Is there a game running
 boolean Playing(void);
 
+// Advance client-to-client pubkey verification flow
+void UpdateChallenges(void);
+
 // Broadcasts special packets to other players
 //  to notify of game exit
 void D_QuitNetGame(void);

src/p_tick.c

@@ -28,6 +28,7 @@
 #include "i_video.h" // rendermode
 #include "r_main.h"
 #include "r_fps.h"
+#include "d_clisrv.h" // UpdateChallenges
 
 // Object place
 #include "m_cheat.h"
@@ -966,6 +967,9 @@ void P_Ticker(boolean run)
 		ps_lua_thinkframe_time = I_GetPreciseTime() - ps_lua_thinkframe_time;
 	}
 
+	if (run)
+		UpdateChallenges();
+
 	// Run shield positioning
 	P_RunOverlays();