Revert "Fix race condition crash when setting element text, bump version to 1.2.0-rc3"

This reverts commit 4934a04d8a.

src/main/main.cpp

@@ -48,7 +48,7 @@
 
 #include "../../lib/rt64/src/contrib/stb/stb_image.h"
 
-const std::string version_string = "1.2.0-rc3";
+const std::string version_string = "1.2.0-rc2";
 
 template<typename... Ts>
 void exit_error(const char* str, Ts ...args) {

src/ui/elements/ui_element.cpp

@@ -355,16 +355,30 @@ bool Element::is_enabled() const {
     return enabled && !disabled_from_parent;
 }
 
+// Adapted from RmlUi's `EncodeRml`.
+std::string escape_rml(std::string_view string)
+{
+	std::string result;
+	result.reserve(string.size());
+	for (char c : string)
+	{
+		switch (c)
+		{
+		case '<': result += "&lt;"; break;
+		case '>': result += "&gt;"; break;
+		case '&': result += "&amp;"; break;
+		case '"': result += "&quot;"; break;
+        case '\n': result += "<br/>"; break;
+		default: result += c; break;
+		}
+	}
+	return result;
+}
+
 void Element::set_text(std::string_view text) {
     if (can_set_text) {
-        if (text_element == nullptr) {
+        // Escape the string into Rml to prevent element injection.
-            Rml::ElementPtr text_element_owning = get_current_context().get_document()->CreateTextNode(std::string{text});
+        base->SetInnerRML(escape_rml(text));
-            text_element = rmlui_static_cast<Rml::ElementText*>(text_element_owning.get());
-            base->AppendChild(std::move(text_element_owning));
-        }
-        else {
-            text_element->SetText(std::string{text});
-        }
     }
     else {
         assert(false && "Attempted to set text of an element that cannot have its text set.");

src/ui/elements/ui_element.h

@@ -25,7 +25,6 @@ class Element : public Style, public Rml::EventListener {
     friend class ContextId; // To allow ContextId to call the handle_event method directly.
 private:
     Rml::Element *base = nullptr;
-    Rml::ElementText *text_element = nullptr;
     Rml::ElementPtr base_owning = {};
     uint32_t events_enabled = 0;
     std::vector<Style *> styles;