mirror of
https://github.com/coop-deluxe/sm64coopdx.git
synced 2026-06-24 00:32:58 +00:00
87f87b5dc9
Some checks are pending
This pr fixes an issue on linux where the function ns_socket_get_id_str always returns empty string. See glibc implementation of vsnprintf : [vsnprintf implementation](https://elixir.bootlin.com/glibc/glibc-2.36/source/libio/vsnprintf.c#L112). First string parameter is "emptied" before starting the copy. And I suspect the original snprintf to rewrite twice the same value in id_str (except if I missed something) so we can just remove it. This issue gives moderator access to all players when they connect/reconnect after adding one player as moderator because all players have the same id : "". How to reproduce : Host server (via socket, not coopnet) on sm64coopdx linux version Add moderator to one player All new connected or reconnected player are promoted to moderator |
||
|---|---|---|
| .. | ||
| coopnet | ||
| packets | ||
| socket | ||
| ban_list.c | ||
| ban_list.h | ||
| lag_compensation.c | ||
| lag_compensation.h | ||
| moderator_list.c | ||
| moderator_list.h | ||
| network.c | ||
| network.h | ||
| network_player.c | ||
| network_player.h | ||
| network_utils.c | ||
| network_utils.h | ||
| sync_object.c | ||
| sync_object.h | ||
| version.c | ||
| version.h | ||